Extract test-test workflow with correct job prerequisites - #170
Merged
fulldecent merged 4 commits intoSep 16, 2025
Conversation
Co-authored-by: fulldecent <382183+fulldecent@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] do this @fulldecent/github-pages-template/issues/169
Extract test-test workflow for parallel test tools validation
Sep 16, 2025
Owner
|
@copilot do yarn lint-fix |
Co-authored-by: fulldecent <382183+fulldecent@users.noreply.github.com>
Contributor
Author
fulldecent
marked this pull request as ready for review
September 16, 2025 21:23
Owner
|
@copilot the prerequisites here are wrong jekyll build should be a prerequisite for testing Test test should also be a prerequisite for testing Jackal build should be a prerequisite for deploying Those are the only prerequisites |
…build is prerequisite for deploy Co-authored-by: fulldecent <382183+fulldecent@users.noreply.github.com>
Contributor
Author
Fixed the workflow prerequisites as requested. Now:
Removed redundant separate test-test.yml workflow and consolidated everything into build-test-deploy.yml with correct dependencies. Changes committed in 5c4ce62. |
Copilot
AI
changed the title
Extract test-test workflow for parallel test tools validation
Extract test-test workflow with correct job prerequisites
Sep 16, 2025
fulldecent
deleted the
copilot/fix-72a91611-784b-4a5a-b6b8-8fb4459c1b64
branch
December 8, 2025 17:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #169 by separating test tools validation into its own workflow job with the correct prerequisite structure.
Changes Made
Package Scripts
test-testscript: Runs test tools validation (fixtures-html-validate-should-fail.mjsandfixtures-structured-data-should-fail.mjs)testscript: Now only runs application tests (build-html-validate.mjs,dirty-file-paths-checker.mjs, andbuild-structured-data-validate.mjs)GitHub Actions Workflow Structure
build-test-deploy.ymlwith proper dependenciestestjob depends onbuild)testjob depends ontest-test)deploy-github-pagesjob depends onbuild)Job Flow
Benefits
Verification
Both test scripts work independently and the workflow has the correct prerequisite structure:
The workflow ensures test-test validation completes before running main tests, while deployment only waits for the build to complete.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.