Skip to content

Extract test-test workflow with correct job prerequisites - #170

Merged
fulldecent merged 4 commits into
mainfrom
copilot/fix-72a91611-784b-4a5a-b6b8-8fb4459c1b64
Sep 16, 2025
Merged

Extract test-test workflow with correct job prerequisites#170
fulldecent merged 4 commits into
mainfrom
copilot/fix-72a91611-784b-4a5a-b6b8-8fb4459c1b64

Conversation

Copilot AI commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

This PR addresses issue #169 by separating test tools validation into its own workflow job with the correct prerequisite structure.

Changes Made

Package Scripts

  • New test-test script: Runs test tools validation (fixtures-html-validate-should-fail.mjs and fixtures-structured-data-should-fail.mjs)
  • Updated test script: Now only runs application tests (build-html-validate.mjs, dirty-file-paths-checker.mjs, and build-structured-data-validate.mjs)

GitHub Actions Workflow Structure

  • Consolidated workflow: All jobs are now in build-test-deploy.yml with proper dependencies
  • Correct prerequisites:
    • Jekyll build is prerequisite for testing (test job depends on build)
    • Test-test is prerequisite for testing (test job depends on test-test)
    • Jekyll build is prerequisite for deploying (deploy-github-pages job depends on build)
    • No other prerequisites exist

Job Flow

build (Jekyll) ──┬──→ test (depends on build + test-test) 
                 │
test-test ───────┘
                 
build ──→ deploy-github-pages (depends only on build)

Benefits

  • Improved CI/CD efficiency: Test tools validation runs in parallel with Jekyll build
  • Clear separation of concerns: Test tool validation is separate from application testing
  • Correct deployment gates: Deployment only requires successful build, allowing faster releases
  • Better failure isolation: Test tool issues don't block deployment if build succeeds

Verification

Both test scripts work independently and the workflow has the correct prerequisite structure:

# Test tools validation
yarn run test-test

# Application tests  
yarn run test

The workflow ensures test-test validation completes before running main tests, while deployment only waits for the build to complete.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: fulldecent <382183+fulldecent@users.noreply.github.com>
Copilot AI changed the title [WIP] do this @fulldecent/github-pages-template/issues/169 Extract test-test workflow for parallel test tools validation Sep 16, 2025
Copilot AI requested a review from fulldecent September 16, 2025 20:37
@fulldecent

Copy link
Copy Markdown
Owner

@copilot do yarn lint-fix

Co-authored-by: fulldecent <382183+fulldecent@users.noreply.github.com>

Copilot AI commented Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

@copilot do yarn lint-fix

Done! Applied yarn lint-fix which fixed formatting issues in .github/workflows/test-test.yml (removed trailing space and added newline at end of file). Changes committed in c57bf00.

@fulldecent
fulldecent marked this pull request as ready for review September 16, 2025 21:23
@fulldecent

Copy link
Copy Markdown
Owner

@copilot the prerequisites here are wrong

jekyll build should be a prerequisite for testing

Test test should also be a prerequisite for testing

Jackal build should be a prerequisite for deploying

Those are the only prerequisites

…build is prerequisite for deploy

Co-authored-by: fulldecent <382183+fulldecent@users.noreply.github.com>

Copilot AI commented Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

@copilot the prerequisites here are wrong

jekyll build should be a prerequisite for testing
...

Fixed the workflow prerequisites as requested. Now:

  • Jekyll build is prerequisite for testing (test needs build)
  • Test-test is prerequisite for testing (test needs test-test)
  • Jekyll build is prerequisite for deploying (deploy-github-pages needs build)
  • No other prerequisites exist

Removed redundant separate test-test.yml workflow and consolidated everything into build-test-deploy.yml with correct dependencies. Changes committed in 5c4ce62.

Copilot AI changed the title Extract test-test workflow for parallel test tools validation Extract test-test workflow with correct job prerequisites Sep 16, 2025
@fulldecent
fulldecent merged commit 642139f into main Sep 16, 2025
9 of 10 checks passed
@fulldecent
fulldecent deleted the copilot/fix-72a91611-784b-4a5a-b6b8-8fb4459c1b64 branch December 8, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants